Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the Azure resource reporting system by adding SKU count tracking throughout the collection, availability checking, and reporting pipeline.
Key changes:
- Modified SKU collection to group and count unique SKUs per resource type
- Updated object comparison logic to exclude the new "count" property when comparing SKUs
- Enhanced report generation to display SKU counts alongside other resource metrics
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| 1-Collect/Get-AzureServices.ps1 | Implements SKU grouping and counting logic using ConvertTo-Json for unique identification, adds "count" property to each SKU object |
| 2-AvailabilityCheck/Get-AvailabilityInformation.ps1 | Updates Compare-ObjectsStrict function to exclude "count" property from comparison logic while maintaining SKU identity matching |
| 7-Report/Get-Report.ps1 | Adds skuCount parameter to Set-SvcAvailReportObj function and includes SKU count in report data for all code paths |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…Selection into include-sku-count
lvlindv
approved these changes
Dec 3, 2025
Collaborator
lvlindv
left a comment
lvlindv
left a comment
There was a problem hiding this comment.
LGTM, tested and works as expected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the count of individual SKUs collected in the reporting.